diff options
| author |   Marlon Rodriguez Garcia <marlon.rodriguez-garcia@savoirfairelinux.com> | 2023-12-14 14:44:09 -0500 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-12-16 13:06:08 +0000 |
| commit | eb417e27be5717a259f27e98dbd73255b1a42fc9 (patch) | |
| tree | 7f3f123b401bf580715054067f11a06072acf627 | |
| parent | 938cba3e80f26589ccbe34483c79e17056346fde (diff) | |
| download | bitbake-contrib-eb417e27be5717a259f27e98dbd73255b1a42fc9.tar.gz | |
toaster: Added validation to stop import if there is a build in progress
Added validation to prevent simultaneous imports from running because the database fails at runtime.
The option to create a queue was taken into consideration. However, it will require the use of Celery https://pypi.org/project/celery/ or Background Task https://pypi.org/project/django-background-tasks/ which require the use of external services and multiple dependencies.
If required we could explore the alternative in the future.
Signed-off-by: Marlon Rodriguez Garcia <marlon.rodriguez-garcia@savoirfairelinux.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/toaster/toastergui/templates/command_line_builds.html | 6 | ||||
| -rw-r--r-- | lib/toaster/toastergui/views.py | 8 |
2 files changed, 13 insertions, 1 deletions
diff --git a/lib/toaster/toastergui/templates/command_line_builds.html b/lib/toaster/toastergui/templates/command_line_builds.html index fcbe80d8d..05db6727e 100644 --- a/lib/toaster/toastergui/templates/command_line_builds.html +++ b/lib/toaster/toastergui/templates/command_line_builds.html @@ -152,7 +152,11 @@ function _ajax_update(file, all, dir){ type: "POST", data: {file: file, all: all, dir: dir}, success:function(data){ - window.location = '/toastergui/builds/' + if (data['response']=='building'){ + location.reload() + } else { + window.location = '/toastergui/builds/' + } }, complete:function(data){ }, diff --git a/lib/toaster/toastergui/views.py b/lib/toaster/toastergui/views.py index 3b5b9f5bd..40aed265d 100644 --- a/lib/toaster/toastergui/views.py +++ b/lib/toaster/toastergui/views.py @@ -2018,6 +2018,14 @@ class CommandLineBuilds(TemplateView): logs_dir = request.POST.get('dir') all_files = request.POST.get('all') + # check if a build is already in progress + if Build.objects.filter(outcome=Build.IN_PROGRESS): + messages.add_message( + self.request, + messages.ERROR, + "A build is already in progress. Please wait for it to complete before starting a new build." + ) + return JsonResponse({'response': 'building'}) imported_files = EventLogsImports.objects.all() try: if all_files == 'true': |