diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-08-22 13:53:11 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-08-23 08:48:45 +0100 |
commit | f1e943aebfb84e98253f3f21646d6765c4fa1d66 (patch) | |
tree | e23a976572b1b7e714ffcf11960b98997edce470 /lib | |
parent | 4664333e55ffc9d618f2c2f074200923209fd6c4 (diff) | |
download | bitbake-contrib-f1e943aebfb84e98253f3f21646d6765c4fa1d66.tar.gz |
methodpool: Clean up the parsed module list handling to be slightly less insane
This removes some dubious functions and replaces them with a simpler, cleaner
API which better describes what the code is doing. Unused code/variables are
removed and comments tweaked.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/bb/methodpool.py | 17 | ||||
-rw-r--r-- | lib/bb/parse/ast.py | 1 | ||||
-rw-r--r-- | lib/bb/parse/parse_py/BBHandler.py | 2 |
3 files changed, 10 insertions, 10 deletions
diff --git a/lib/bb/methodpool.py b/lib/bb/methodpool.py index 3b8e5c113..2fb5d96a3 100644 --- a/lib/bb/methodpool.py +++ b/lib/bb/methodpool.py @@ -33,9 +33,7 @@ from bb.utils import better_compile, better_exec from bb import error -# A dict of modules we have handled -# it is the number of .bbclasses + x in size -_parsed_methods = { } +# A dict of function names we have seen _parsed_fns = { } def insert_method(modulename, code, fn): @@ -56,15 +54,18 @@ def insert_method(modulename, code, fn): else: _parsed_fns[name] = modulename +# A dict of modules the parser has finished with +_parsed_methods = {} + def parsed_module(modulename): """ - Inform me file xyz was parsed + Has module been parsed? """ return modulename in _parsed_methods - -def get_parsed_dict(): +def set_parsed_module(modulename): """ - shortcut + Set module as parsed """ - return _parsed_methods + _parsed_methods[modulename] = True + diff --git a/lib/bb/parse/ast.py b/lib/bb/parse/ast.py index b88d5f5b3..4d3a623aa 100644 --- a/lib/bb/parse/ast.py +++ b/lib/bb/parse/ast.py @@ -31,7 +31,6 @@ import itertools from bb import methodpool from bb.parse import logger -__parsed_methods__ = bb.methodpool.get_parsed_dict() _bbversions_re = re.compile(r"\[(?P<from>[0-9]+)-(?P<to>[0-9]+)\]") class StatementGroup(list): diff --git a/lib/bb/parse/parse_py/BBHandler.py b/lib/bb/parse/parse_py/BBHandler.py index 625a2a21f..2e0647b5d 100644 --- a/lib/bb/parse/parse_py/BBHandler.py +++ b/lib/bb/parse/parse_py/BBHandler.py @@ -161,7 +161,7 @@ def handle(fn, d, include): # we have parsed the bb class now if ext == ".bbclass" or ext == ".inc": - bb.methodpool.get_parsed_dict()[base_name] = 1 + bb.methodpool.set_parsed_module(base_name) return d |