From 85b39219d203dcdd83157fb14be8725d7fc2b0eb Mon Sep 17 00:00:00 2001 From: Ross Burton Date: Fri, 3 Nov 2017 11:48:36 +0000 Subject: tests/fetch: use subtests in the wget tests As we test multiple URLs in this these tests and one failing abandons the test, use subtests so all URLs are tested. This should help us identify patterns in the failing URLs. Signed-off-by: Ross Burton Signed-off-by: Richard Purdie (cherry picked from commit c4c4465b32e82d4b6e46a44e776be5039aef6b18) Signed-off-by: Armin Kuster --- lib/bb/tests/fetch.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/bb/tests/fetch.py b/lib/bb/tests/fetch.py index f1799a7ef..b07bf0047 100644 --- a/lib/bb/tests/fetch.py +++ b/lib/bb/tests/fetch.py @@ -848,10 +848,11 @@ class FetchCheckStatusTest(FetcherTest): def test_wget_checkstatus(self): fetch = bb.fetch2.Fetch(self.test_wget_uris, self.d) for u in self.test_wget_uris: - ud = fetch.ud[u] - m = ud.method - ret = m.checkstatus(fetch, ud, self.d) - self.assertTrue(ret, msg="URI %s, can't check status" % (u)) + with self.subTest(url=u): + ud = fetch.ud[u] + m = ud.method + ret = m.checkstatus(fetch, ud, self.d) + self.assertTrue(ret, msg="URI %s, can't check status" % (u)) @skipIfNoNetwork() def test_wget_checkstatus_connection_cache(self): @@ -862,10 +863,11 @@ class FetchCheckStatusTest(FetcherTest): connection_cache = connection_cache) for u in self.test_wget_uris: - ud = fetch.ud[u] - m = ud.method - ret = m.checkstatus(fetch, ud, self.d) - self.assertTrue(ret, msg="URI %s, can't check status" % (u)) + with self.subTest(url=u): + ud = fetch.ud[u] + m = ud.method + ret = m.checkstatus(fetch, ud, self.d) + self.assertTrue(ret, msg="URI %s, can't check status" % (u)) connection_cache.close_connections() -- cgit 1.2.3-korg