From a0eaf8c0f228f984bafff09e4e9739f758dc1a9b Mon Sep 17 00:00:00 2001 From: Mark Hatle Date: Sat, 2 Sep 2017 10:09:43 -0500 Subject: cooker.py: Fix layer priority processing If you have a layer with a blank BBFILE_PATTERN the layer was ignored when processing the list of layers with priorities. This list is not only used for processing recipes, but also by additional programs such as bitbake-layers show-layers. Without this change, a layer that provides configuration or classes only does now show up in show-layers, which is used by the yocto-compat-layer.py script. This causes a failures in the compatibility check. Signed-off-by: Mark Hatle Signed-off-by: Richard Purdie --- lib/bb/cooker.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py index f5ae831c4..90de40d64 100644 --- a/lib/bb/cooker.py +++ b/lib/bb/cooker.py @@ -1171,13 +1171,13 @@ class BBCooker: elif regex == "": parselog.debug(1, "BBFILE_PATTERN_%s is empty" % c) errors = False - continue - try: - cre = re.compile(regex) - except re.error: - parselog.error("BBFILE_PATTERN_%s \"%s\" is not a valid regular expression", c, regex) - errors = True - continue + else: + try: + cre = re.compile(regex) + except re.error: + parselog.error("BBFILE_PATTERN_%s \"%s\" is not a valid regular expression", c, regex) + errors = True + continue self.bbfile_config_priorities.append((c, regex, cre, collection_priorities[c])) if errors: # We've already printed the actual error(s) -- cgit 1.2.3-korg