diff options
| author |   David Khouya <dakhouya@gmail.com> | 2020-07-01 12:27:40 -0400 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2020-07-02 16:16:17 +0100 |
| commit | 2a2c507f239b047f34765312df4168030e38b90d (patch) | |
| tree | 1ee98107cbd5cfe9303d8f9c9f9fd07b82b448ee | |
| parent | 41988fec47eb196ab7195a75330a6d98de19101b (diff) | |
| download | bitbake-2a2c507f239b047f34765312df4168030e38b90d.tar.gz | |
lib/ui/taskexp: Validate gi import
When running bitbake -g -u taskexp without having gi python module or
and invalid gtk version, bitbake fails with a stack trace.
In case of import or version error, bitbake should exit with an error
message instead of a stack trace.
Signed-off-by: David Khouya <dakhouya@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/bb/ui/taskexp.py | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/lib/bb/ui/taskexp.py b/lib/bb/ui/taskexp.py index 8fff24423..336d197de 100644 --- a/lib/bb/ui/taskexp.py +++ b/lib/bb/ui/taskexp.py @@ -8,9 +8,15 @@ # import sys -import gi -gi.require_version('Gtk', '3.0') -from gi.repository import Gtk, Gdk, GObject + +try: + import gi + gi.require_version('Gtk', '3.0') +except ValueError: + sys.exit("FATAL: Gtk version needs to be 3.0") +except ImportError: + sys.exit("FATAL: Gtk ui could not load the required gi python module") + import threading from xmlrpc import client import bb |