From be022085fe1ea1b9a9d519f0455883e2da363d2c Mon Sep 17 00:00:00 2001 From: Christopher Larson Date: Fri, 18 Jan 2019 21:45:55 +0500 Subject: bb.tests.codeparser: add parameter expansion modifiers test We don't want references including shell parameter expansion modifiers (i.e. `:-`, `#`, `%%`, etc) to be added to our vardeps, so add a test to ensure this. YOCTO #12987 Signed-off-by: Christopher Larson Signed-off-by: Richard Purdie --- lib/bb/tests/codeparser.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/bb/tests/codeparser.py b/lib/bb/tests/codeparser.py index e30e78c15..3fd76a8f9 100644 --- a/lib/bb/tests/codeparser.py +++ b/lib/bb/tests/codeparser.py @@ -123,6 +123,13 @@ ${D}${libdir}/pkgconfig/*.pc self.parseExpression("sed -i -e 's:IP{:I${:g' $pc") self.assertExecs(set(["sed"])) + def test_parameter_expansion_modifiers(self): + # - and + are also valid modifiers for parameter expansion, but are + # valid characters in bitbake variable names, so are not included here + for i in ('=', ':-', ':=', '?', ':?', ':+', '#', '%', '##', '%%'): + name = "foo%sbar" % i + self.parseExpression("${%s}" % name) + self.assertNotIn(name, self.references) def test_until(self): self.parseExpression("until false; do echo true; done") -- cgit 1.2.3-korg