summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Lehtonen <markus.lehtonen@linux.intel.com>2016-06-30 15:53:52 +0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-08-17 10:35:26 +0100
commit240f6e7366c8a9ea830e531d307dd2e27a61a6bd (patch)
tree8c174c7e5f777797bfbad3409a1d6646be60fa23
parentd28eeeabde9b4b7160a273445023a44fd50e29ab (diff)
downloadopenembedded-core-contrib-240f6e7366c8a9ea830e531d307dd2e27a61a6bd.tar.gz
openembedded-core-contrib-240f6e7366c8a9ea830e531d307dd2e27a61a6bd.tar.bz2
openembedded-core-contrib-240f6e7366c8a9ea830e531d307dd2e27a61a6bd.zip
oeqa.buildperf: be more verbose about failed commands
Log failures of commands whose output is stored. Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
-rw-r--r--meta/lib/oeqa/buildperf/base.py12
1 files changed, 9 insertions, 3 deletions
diff --git a/meta/lib/oeqa/buildperf/base.py b/meta/lib/oeqa/buildperf/base.py
index 52c2ab61bf..fe18181f2b 100644
--- a/meta/lib/oeqa/buildperf/base.py
+++ b/meta/lib/oeqa/buildperf/base.py
@@ -23,7 +23,7 @@ import unittest
from datetime import datetime, timedelta
from functools import partial
-from oeqa.utils.commands import runCmd, get_bb_vars
+from oeqa.utils.commands import CommandError, runCmd, get_bb_vars
from oeqa.utils.git import GitError, GitRepo
# Get logger for this module
@@ -216,9 +216,15 @@ class BuildPerfTestCase(unittest.TestCase):
def log_cmd_output(self, cmd):
"""Run a command and log it's output"""
+ cmd_str = cmd if isinstance(cmd, str) else ' '.join(cmd)
+ log.info("Logging command: %s", cmd_str)
cmd_log = os.path.join(self.out_dir, 'commands.log')
- with open(cmd_log, 'a') as fobj:
- runCmd2(cmd, stdout=fobj)
+ try:
+ with open(cmd_log, 'a') as fobj:
+ runCmd2(cmd, stdout=fobj)
+ except CommandError as err:
+ log.error("Command failed: %s", err.retcode)
+ raise
def measure_cmd_resources(self, cmd, name, legend):
"""Measure system resource usage of a command"""