aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMaxin B. John <maxin.john@intel.com>2016-09-25 21:40:05 +0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-09-28 10:16:03 +0100
commit850ded308cd55df6722725c4f8356178ee2ef3ad (patch)
tree1b82064a3642488ca9e7ebddef8fc95f7e267b7d
parent013fff4639c7f333eca350ca6b6c013296d9598f (diff)
downloadopenembedded-core-contrib-850ded308cd55df6722725c4f8356178ee2ef3ad.tar.gz
openembedded-core-contrib-850ded308cd55df6722725c4f8356178ee2ef3ad.tar.bz2
openembedded-core-contrib-850ded308cd55df6722725c4f8356178ee2ef3ad.zip
gst-player: Disable visualizations
On some machines, visualizations in gst-player trigger a bug in xvimagesink. Till we have a proper fix, disable the visualization rather than downgrading the xvimagesink. Fixes [YOCTO #10041] (From OE-Core rev: b79d1bf49b56a97216fb719ac19e4dd9022f15b4) Signed-off-by: Maxin B. John <maxin.john@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch36
-rw-r--r--meta/recipes-multimedia/gstreamer/gst-player_git.bb1
2 files changed, 37 insertions, 0 deletions
diff --git a/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch b/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch
new file mode 100644
index 0000000000..dabdcea345
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch
@@ -0,0 +1,36 @@
+From 93e1838f8b8704e4d7d71965f61bee931377b080 Mon Sep 17 00:00:00 2001
+From: Jussi Kukkonen <jussi.kukkonen@intel.com>
+Date: Thu, 22 Sep 2016 19:26:40 +0300
+Subject: [PATCH] Disable visualizations by default
+
+As documented in [YOCTO #10041] visualizations trigger a bug in
+xvimagesink on some hardware, which prevents playback in the
+mediaplayer. Disable visualizations until the xv issue is solved
+to enable playback QA.
+
+Upstream-Status: Inappropriate [workaround]
+Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
+Signed-off-by: Maxin B. John <maxin.john@intel.com>
+---
+ gtk/gtk-play.c | 5 ++---
+ 1 file changed, 2 insertions(+), 3 deletions(-)
+
+diff --git a/gtk/gtk-play.c b/gtk/gtk-play.c
+index 8ae0fea..322e599 100644
+--- a/gtk/gtk-play.c
++++ b/gtk/gtk-play.c
+@@ -1751,9 +1751,8 @@ gtk_play_constructor (GType type, guint n_construct_params,
+ g_signal_connect (self->player, "volume-changed",
+ G_CALLBACK (player_volume_changed_cb), self);
+
+- /* enable visualization (by default playbin uses goom) */
+- /* if visualization is enabled then use the first element */
+- gst_player_set_visualization_enabled (self->player, TRUE);
++ /* Disable visualization by default */
++ gst_player_set_visualization_enabled (self->player, FALSE);
+
+ g_signal_connect (G_OBJECT (self), "show", G_CALLBACK (show_cb), NULL);
+
+--
+2.4.0
+
diff --git a/meta/recipes-multimedia/gstreamer/gst-player_git.bb b/meta/recipes-multimedia/gstreamer/gst-player_git.bb
index 2a4c9dcfbf..51f3544599 100644
--- a/meta/recipes-multimedia/gstreamer/gst-player_git.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-player_git.bb
@@ -9,6 +9,7 @@ SRC_URI = "git://github.com/sdroege/gst-player.git \
file://Fix-pause-play.patch;apply=0 \
file://Add-error-signal-emission-for-missing-plugins.patch;apply=0 \
file://0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch \
+ file://0001-Disable-visualizations-by-default.patch \
file://gst-player.desktop"
SRCREV = "ea90e63c1064503f9ba5d59aa4ca604f13ca5def"