summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRandy Witt <randy.e.witt@linux.intel.com>2017-01-18 10:31:51 -0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2017-02-19 06:47:09 -0800
commitf0645e172bb839803d616f19307e1e81e0d204c0 (patch)
tree5777f6fbda2fd51f75f8bf5af5e28d1ae2fef976
parente45f074b792a43aa2fd84a5a3f0e20bf1d88ad7e (diff)
downloadopenembedded-core-contrib-f0645e172bb839803d616f19307e1e81e0d204c0.tar.gz
openembedded-core-contrib-f0645e172bb839803d616f19307e1e81e0d204c0.tar.bz2
openembedded-core-contrib-f0645e172bb839803d616f19307e1e81e0d204c0.zip
image-container.bbclass: Error if not using linux-dummy
In the typical case of a container, the user doesn't particularly care about the kernel version used. Since using linux-dummy prevents building a kernel in the most common case, alert the user if they choose a container image, but don't also specify linux-dummy. In the cases the user actually does want to build against particular kernel headers, etc, they can override by setting IMAGE_CONTAINER_NO_DUMMY = "1". [YOCTO #9502] Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
-rw-r--r--meta/classes/image-container.bbclass18
1 files changed, 18 insertions, 0 deletions
diff --git a/meta/classes/image-container.bbclass b/meta/classes/image-container.bbclass
index a10ee326ce..f002858bd2 100644
--- a/meta/classes/image-container.bbclass
+++ b/meta/classes/image-container.bbclass
@@ -1,3 +1,21 @@
ROOTFS_BOOTSTRAP_INSTALL = ""
IMAGE_TYPES_MASKED += "container"
IMAGE_TYPEDEP_container = "tar.bz2"
+
+python __anonymous() {
+ if "container" in d.getVar("IMAGE_FSTYPES") and \
+ d.getVar("IMAGE_CONTAINER_NO_DUMMY") != "1" and \
+ "linux-dummy" not in d.getVar("PREFERRED_PROVIDER_virtual/kernel"):
+ msg = '"container" is in IMAGE_FSTYPES, but ' \
+ 'PREFERRED_PROVIDER_virtual/kernel is not "linux-dummy". ' \
+ 'Unless a particular kernel is needed, using linux-dummy will ' \
+ 'prevent a kernel from being built, which can reduce ' \
+ 'build times. If you don\'t want to use "linux-dummy", set ' \
+ '"IMAGE_CONTAINER_NO_DUMMY" to "1".'
+
+ # Raising skip recipe was Paul's clever idea. It causes the error to
+ # only be shown for the recipes actually requested to build, rather
+ # than bb.fatal which would appear for all recipes inheriting the
+ # class.
+ raise bb.parse.SkipRecipe(msg)
+}