From 126dfefb5fddf411ad0a1316209e9c1b47abfcd2 Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Wed, 9 Feb 2022 17:30:16 -0800 Subject: [PATCH] man: Move local variable declaration to function scope There is a clang bug [1] unearthed here, so help clang by re-arranging code without changing the logic, until its fixed in clang [1] https://github.com/llvm/llvm-project/issues/53692 Upstream-Status: Inappropriate [Inappropriate: Clang bug] Signed-off-by: Khem Raj --- src/man.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/man.c b/src/man.c index f16fae8..333df03 100644 --- a/src/man.c +++ b/src/man.c @@ -352,7 +352,7 @@ static void init_html_pager (void) static error_t parse_opt (int key, char *arg, struct argp_state *state) { static bool apropos, whatis; /* retain values between calls */ - + char *s; /* Please keep these keys in the same order as in options above. */ switch (key) { case 'C': @@ -384,7 +384,7 @@ static error_t parse_opt (int key, char *arg, struct argp_state *state) case OPT_WARNINGS: #ifdef NROFF_WARNINGS { - char *s = xstrdup + s = xstrdup (arg ? arg : default_roff_warnings); const char *warning;