summaryrefslogtreecommitdiffstats
path: root/meta/classes/cml1.bbclass
diff options
context:
space:
mode:
authorMikko Rapeli <mikko.rapeli@bmw.de>2017-06-22 16:23:14 +0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2017-06-28 20:54:52 +0100
commit578c8205fd14c48c6d30ef2889d86f1b4aee060a (patch)
tree1568d08b0881ea3cd6f14a27833b144595fd0ca6 /meta/classes/cml1.bbclass
parentdf850ff9e101afcc9983f907570abaf17421ba0f (diff)
downloadopenembedded-core-578c8205fd14c48c6d30ef2889d86f1b4aee060a.tar.gz
openembedded-core-578c8205fd14c48c6d30ef2889d86f1b4aee060a.tar.bz2
openembedded-core-578c8205fd14c48c6d30ef2889d86f1b4aee060a.zip
meta: Fix return value checks from subprocess.call()'s
Python function subprocess.call() returns the return value of the executed process. If return values are not checked, errors may go unnoticed and bad things can happen. Change all callers of subprocess.call() which do not check for the return value to use subprocess.check_call() which raises CalledProcessError if the subprocess returns with non-zero value. https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module All users of the function were found with: $ git grep "subprocess\.call" | \ egrep -v 'if.*subprocess\.call|=\ +subprocess\.call|return.*subprocess\.call' Tested similar patch on top of yocto jethro. Only compile tested core-image-minimal on poky master branch. Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de> Signed-off-by: Ross Burton <ross.burton@intel.com>
Diffstat (limited to 'meta/classes/cml1.bbclass')
-rw-r--r--meta/classes/cml1.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index 38e6613c48..eb8e7907f6 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -63,7 +63,7 @@ python do_diffconfig() {
if isdiff:
statement = 'diff --unchanged-line-format= --old-line-format= --new-line-format="%L" ' + configorig + ' ' + config + '>' + fragment
- subprocess.call(statement, shell=True)
+ subprocess.check_call(statement, shell=True)
shutil.copy(configorig, config)