diff options
| author |   Robert Yang <liezhi.yang@windriver.com> | 2012-05-29 22:53:08 +0800 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-05-30 10:58:10 +0100 |
| commit | e83d8e58a6b107eea87df0ec233a1bc932b2c6ea (patch) | |
| tree | 7373c71af06a1cc504ee251615c80ae3c07e6347 /meta/classes/kernel.bbclass | |
| parent | 57f843146ed62c04c23bc380dc8cb38aba264f1c (diff) | |
| download | openembedded-core-e83d8e58a6b107eea87df0ec233a1bc932b2c6ea.tar.gz | |
meta: replace os.popen with subprocess.Popen
Replace os.popen with subprocess.Popen since the older function would
fail (more or less) silently if the executed program cannot be found
There are both bb.process.run() and bb.process.Popen() which wraps the
subprocess module, use it for simplifying the code.
Note: We don't need the "2>/dev/null" or "2>&1" since bb.process.run()
can handle it, it will raise exception when error occurs, we should
handle the exception ourselves if we want to ignore the error.
More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements
[YOCTO #2454]
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/kernel.bbclass')
| -rw-r--r-- | meta/classes/kernel.bbclass | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index 116e10b9de..d74361bf93 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -349,7 +349,7 @@ python populate_packages_prepend () { path = d.getVar("PATH", True) cmd = "PATH=\"%s\" depmod -n -a -b %s -F %s/boot/System.map-%s %s" % (path, dvar, dvar, kernelver, kernelver_stripped) - f = os.popen(cmd, 'r') + f = bb.process.Popen(cmd, shell=True).stdout deps = {} pattern0 = "^(.*\.k?o):..*$" |