diff options
| author |   Ulf Magnusson <ulfalizer@gmail.com> | 2016-10-01 04:47:06 +0200 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-10-03 15:46:21 +0100 |
| commit | 086240468265dc15c5b4cdb2594d5aa7c3114dda (patch) | |
| tree | 1ee42179d9def126992f258d774a6d8a6c172df5 /meta/classes | |
| parent | 20e669f56489b2c8a9bc6a0e6f3eac81ef35445a (diff) | |
| download | openembedded-core-086240468265dc15c5b4cdb2594d5aa7c3114dda.tar.gz | |
testsdk.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.
Motivating quote below:
< kergoth> the *original* intent was for the function/task to error via
whatever appropriate means, bb.fatal, whatever, and
funcfailed was what you'd catch if you were calling
exec_func/exec_task. that is, it's what those functions
raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself
FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes')
| -rw-r--r-- | meta/classes/testsdk.bbclass | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/testsdk.bbclass b/meta/classes/testsdk.bbclass index 0b8716edb5..77c9203cf9 100644 --- a/meta/classes/testsdk.bbclass +++ b/meta/classes/testsdk.bbclass @@ -44,7 +44,7 @@ def run_test_context(CTestContext, d, testdir, tcname, pn, *args): msg += " (skipped=%d)" % skipped bb.plain(msg) else: - raise bb.build.FuncFailed("%s - FAILED - check the task log and the commands log" % pn ) + bb.fatal("%s - FAILED - check the task log and the commands log" % pn) def testsdk_main(d): import os |