path: root/scripts/lib
diff options
authorPaul Eggleton <>2017-10-02 15:45:49 +1300
committerRichard Purdie <>2017-11-10 14:44:31 +0000
commitab1b8d55e551fea3e8656aab7a786d1bfec62d0f (patch)
treed385e3b52a99eb4578203d8abcee99dd012d475b /scripts/lib
parentbfebd18982c0c82ef2da63ec8f22175c93b2e308 (diff)
devtool: finish: fix "layer not in bblayers.conf" warning when path specified
devtool finish will check if the destination layer is part of bblayers.conf so that we avoid the user getting confused about the recipe vanishing from their configuration if it isn't. devtool finish also accepts a path underneath a layer so that you have a bit more control over where it ends up. However if you used a path underneath a layer then it wasn't converting this to the base of the layer before checking it against BBLAYERS, thus the warning was being shown erroneously in that case. Signed-off-by: Paul Eggleton <> Signed-off-by: Ross Burton <>
Diffstat (limited to 'scripts/lib')
1 files changed, 4 insertions, 2 deletions
diff --git a/scripts/lib/devtool/ b/scripts/lib/devtool/
index 7fee304572..166862f12f 100644
--- a/scripts/lib/devtool/
+++ b/scripts/lib/devtool/
@@ -1714,6 +1714,8 @@ def finish(args, config, basepath, workspace):
elif line.startswith('# original_files:'):
origfilelist = line.split(':')[1].split()
+ destlayerbasedir = oe.recipeutils.find_layerdir(destlayerdir)
if origlayerdir == config.workspace_path:
# Recipe file itself is in workspace, update it there first
appendlayerdir = None
@@ -1727,7 +1729,7 @@ def finish(args, config, basepath, workspace):
raise DevtoolError("Unable to determine destination layer path - check that %s specifies an actual layer and %s/conf/layer.conf specifies BBFILES. You may also need to specify a more complete path." % (args.destination, destlayerdir))
# Warn if the layer isn't in bblayers.conf (the code to create a bbappend will do this in other cases)
layerdirs = [os.path.abspath(layerdir) for layerdir in rd.getVar('BBLAYERS').split()]
- if not os.path.abspath(destlayerdir) in layerdirs:
+ if not os.path.abspath(destlayerbasedir) in layerdirs:
bb.warn('Specified destination layer is not currently enabled in bblayers.conf, so the %s recipe will now be unavailable in your current configuration until you add the layer there' % args.recipename)
elif destlayerdir == origlayerdir:
@@ -1740,7 +1742,7 @@ def finish(args, config, basepath, workspace):
destpath = None
# Remove any old files in the case of an upgrade
- if origpath and origfilelist and oe.recipeutils.find_layerdir(origpath) == oe.recipeutils.find_layerdir(destlayerdir):
+ if origpath and origfilelist and oe.recipeutils.find_layerdir(origpath) == destlayerbasedir:
for fn in origfilelist:
fnp = os.path.join(origpath, fn)