diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2018-11-28 17:31:39 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2018-12-01 11:37:49 +0000 |
| commit | 17a0a067d597c445c5892ff9914e91a2187f7e09 (patch) | |
| tree | 548bd5516fd0b8eed891fcff1c55705801e45a8b /scripts/runqemu | |
| parent | 58e48211f7cb44d959b571d449a94291c27535a5 (diff) | |
| download | openembedded-core-17a0a067d597c445c5892ff9914e91a2187f7e09.tar.gz | |
scripts/runqemu: Improve lockfile handling for python with close_fd=True
On python versions with close_fds=True (python 3.2 onwards), the tap
device lockfile isn't passed to the child process.
Since this guards against use of an active interface, we really want this
here, so pass it in pass_fds. This means if the parent exits early, the child
still holds the lock, avoiding messages like:
runqemu - ERROR - Failed to run qemu: qemu-system-x86_64: could not configure /dev/net/tun (tap0): Device or resource busy
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts/runqemu')
| -rwxr-xr-x | scripts/runqemu | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/scripts/runqemu b/scripts/runqemu index d25de42f27..f661892aec 100755 --- a/scripts/runqemu +++ b/scripts/runqemu @@ -1220,7 +1220,10 @@ class BaseConfig(object): cmd = "%s %s" % (self.qemu_opt, kernel_opts) cmds = shlex.split(cmd) logger.info('Running %s\n' % cmd) - process = subprocess.Popen(cmds, stderr=subprocess.PIPE) + pass_fds = [] + if self.lock_descriptor: + pass_fds = [self.lock_descriptor.fileno()] + process = subprocess.Popen(cmds, stderr=subprocess.PIPE, pass_fds=pass_fds) self.qemupid = process.pid retcode = process.wait() if retcode: |