aboutsummaryrefslogtreecommitdiffstats
path: root/classes
diff options
context:
space:
mode:
authorTom Rini <trini@embeddedalley.com>2009-04-28 15:45:36 -0700
committerTom Rini <trini@embeddedalley.com>2009-04-28 15:45:36 -0700
commit07e54135f7c6f9fad09cbbd5c5bb960f53d7587c (patch)
tree8395be61b1e2ba9937cbce971a310262f0cae4c5 /classes
parent7e110765a91ac287ab03f309c6f56bf5cb2935f9 (diff)
downloadopenembedded-07e54135f7c6f9fad09cbbd5c5bb960f53d7587c.tar.gz
openembedded-07e54135f7c6f9fad09cbbd5c5bb960f53d7587c.tar.bz2
openembedded-07e54135f7c6f9fad09cbbd5c5bb960f53d7587c.zip
insane.bbclass: Split package_qa_check_devdbg and don't run -dev check on SDK packages.
We create package_qa_check_dev/package_qa_check_dbg checks. While in here clarify the comments as to what both are doing. Since SDK packages don't get split like normal ones, it's OK to have -dev stuff in non-dev packages. Suggested by Richard Purdie Acked-by: Koen Kooi <koen@openembedded.org> Signed-off-by: Tom Rini <trini@embeddedalley.com>
Diffstat (limited to 'classes')
-rw-r--r--classes/insane.bbclass25
1 files changed, 20 insertions, 5 deletions
diff --git a/classes/insane.bbclass b/classes/insane.bbclass
index 584a5f1c1e..cc881dc0d8 100644
--- a/classes/insane.bbclass
+++ b/classes/insane.bbclass
@@ -250,21 +250,35 @@ def package_qa_check_rpath(file,name,d, elf):
return sane
-def package_qa_check_devdbg(path, name,d, elf):
+def package_qa_check_dev(path, name,d, elf):
"""
- Check for debug remains inside the binary or
- non dev packages containing
+ Check for ".so" library symlinks in non-dev packages
"""
import bb, os
sane = True
+ # SDK packages are special.
+ for s in ['sdk', 'canadian-sdk']:
+ if bb.data.inherits_class(s, d):
+ return True
+
if not "-dev" in name:
if path[-3:] == ".so" and os.path.islink(path):
error_msg = "non -dev package contains symlink .so: %s path '%s'" % \
(name, package_qa_clean_path(path,d))
sane = package_qa_handle_error(0, error_msg, name, path, d)
+ return sane
+
+def package_qa_check_dbg(path, name,d, elf):
+ """
+ Check for ".debug" files or directories outside of the dbg package
+ """
+
+ import bb, os
+ sane = True
+
if not "-dbg" in name:
if '.debug' in path:
error_msg = "non debug package contains .debug directory: %s path %s" % \
@@ -493,9 +507,10 @@ python do_package_qa () {
if not packages:
return
- checks = [package_qa_check_rpath, package_qa_check_devdbg,
+ checks = [package_qa_check_rpath, package_qa_check_dev,
package_qa_check_perm, package_qa_check_arch,
- package_qa_check_desktop, package_qa_hash_style]
+ package_qa_check_desktop, package_qa_hash_style,
+ package_qa_check_dbg]
walk_sane = True
rdepends_sane = True
for package in packages.split():