aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Baryshkov <dbaryshkov@gmail.com>2021-08-18 18:39:32 +0300
committerKhem Raj <raj.khem@gmail.com>2021-08-30 13:44:23 -0700
commitfe90d2095326068cdc3744a3fe56762e3e4562ce (patch)
treef9b52c175ab62dc85860a7e153cb9f8f537fe305
parent455661a33a11c0b335a44b0267d90602a442eb2b (diff)
downloadmeta-openembedded-contrib-fe90d2095326068cdc3744a3fe56762e3e4562ce.tar.gz
image_types_sparse: stop using ext2simg
Under some conditions ext2simg can corrupt the file system (see https://lore.kernel.org/linux-ext4/CAP71WjwVdqmLEq1NGWK36JkEd-i05YcAu4jeY6GFjsk6TS=Mtg@mail.gmail.com/). This has been reproduced with the ext2simg currently found meta-oe's android-tools-native). Stop using ext2simg and always use img2simg. This results in bigger images, but without the risk of image corruption. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r--meta-oe/classes/image_types_sparse.bbclass12
1 files changed, 2 insertions, 10 deletions
diff --git a/meta-oe/classes/image_types_sparse.bbclass b/meta-oe/classes/image_types_sparse.bbclass
index 65d980fd91..4263593a8d 100644
--- a/meta-oe/classes/image_types_sparse.bbclass
+++ b/meta-oe/classes/image_types_sparse.bbclass
@@ -2,15 +2,7 @@ inherit image_types
CONVERSIONTYPES += "sparse"
CONVERSION_CMD:sparse = " \
- case "${type}" in \
- ext*) \
- ext2simg "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" \
- "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.sparse" \
- ;; \
- *) \
- img2simg "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" \
- "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.sparse" \
- ;; \
- esac \
+ img2simg "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" \
+ "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.sparse" \
"
CONVERSION_DEPENDS_sparse = "android-tools-native"