aboutsummaryrefslogtreecommitdiffstats
path: root/meta-oe/recipes-support/lvm2
AgeCommit message (Collapse)Author
2021-05-17libdevmapper,lvm2: Do not inherit licenseKhem Raj
inheriting license class which brings in AVAILABLE_LICENSES into do_configure task checksums class since it wants to enable thin-provisioning-tools if distro allows GPL-3 automatically, but this brings issues when other layers which have additional licenses are provided which ends up in signature mismatches so leave that setting to end-user and keep it disabled by default with a comment in recipes stating that if needed then the user should enable it via config metadata or bbappends. Signed-off-by: Khem Raj <raj.khem@gmail.com> (cherry picked from commit f592e81f11d455546447ddff35b2f89e18c0cc0c) Signed-off-by: Armin Kuster <akuster808@gmail.com>
2021-03-02lvm2/libdevmapper: 2.03.06 -> 2.03.11Hongxu Jia
Drop backport patch: - 0001-dev-hdc-open-failed-No-medium-found-will-print-out-i.patch Refresh: - 0001-fix-command-bin-findmnt-bin-lsblk-bin-sort-not-found.patch Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-11-08lvm2.inc: switch branch master to mainHongxu Jia
Keep sync with upstream Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-07-28lvm2: allow for reproducible binary buildsSlater, Joseph
Modify original method to eliminate conditional patching of configure.ac. Use SOURCE_DATE_EPOCH which is required for reproducible binaries. Signed-off-by: Joe Slater <joe.slater@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-07-20lvm2: reproducible binariesSlater, Joseph
For reproducible binaries, create a static CONFIGURE_LINE during configuration rather than reporting the command line invoking configure. Signed-off-by: Joe Slater <joe.slater@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-06-08lvm2: remove service template from SYSTEMD_SERVICEKai Kang
Remove systemd service template lvm2-pvscan@.service from SYSTEMD_SERVICE. It should be started/stopped in udev rules file 69-dm-lvm-metad.rules. Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-11-06lvm2/libdevmapper: 2.03.05 -> 2.03.06Zheng Ruoqin
1) Remove five patches for they have been merged in new version. 0001-udev-remove-unsupported-OPTIONS-event_timeout-rule.patch 0001-configure-Fix-setting-of-CLDFLAGS-default.patch 0001-activation-add-synchronization-point.patch 0002-activation-extend-handling-of-pending_delete.patch 0003-snapshot-always-activate.patch Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-10-17lvm2/libdevmapper: 2.03.02 -> 2.03.05Hongxu Jia
1. Change to git repo 2. Backport three patches to fix the following issue: While commit [cd735ab1df systemd: upgrade to 243] applied in oe-core, lvmremove hung as following steps: ... dd if=/dev/zero of=./p0 bs=1M count=100 dd if=/dev/zero of=./p1 bs=1M count=100 losetup /dev/loop20 ./p0 losetup /dev/loop21 ./p1 pvcreate -y /dev/loop20 -ff pvcreate -y /dev/loop21 -ff vgcreate rootvg /dev/loop20 /dev/loop21 lvcreate -v -y -L 50 -n rootlv rootvg mkfs -t ext4 /dev/rootvg/rootlv mkdir -p ./lv mount /dev/rootvg/rootlv ./lv lvcreate -v -L 50 -s -n backup /dev/rootvg/rootlv lvconvert -v --merge -i 1 /dev/rootvg/backup umount ./lv vgchange -v -an vgchange -v -ay lvremove -f /dev/rootvg/rootlv ... Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-10-10lvm2: remove unsupported OPTIONS+="event_timeout" ruleHongxu Jia
The OPTIONS+="event_timeout" is Unsupported since systemd/udev version 216, that is ~5 years ago. Since systemd/udev version 243, there's a new message printed if unsupported OPTIONS value is used: Invalid value for OPTIONS key, ignoring: 'event_timeout=180' Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1740666 The fix works on lvm2, it is not necessary for libdevmapper Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-09-30lvm2: fix run lvcreate hung while PACKAGECONFIG udevHongxu Jia
Since lvm2-udevrules was removed from lvm RRECOMMENDS in the following commit: [3f64779ea libdevmapper/lvm2: force recipe libdevmapper to populate sysroot only] Execute the following command hung: $ dd if=/dev/zero of=./p0 bs=1M count=100 $ dd if=/dev/zero of=./p1 bs=1M count=100 $ losetup /dev/loop20 ./p0 $ losetup /dev/loop21 ./p1 $ pvcreate -y /dev/loop20 -ff $ pvcreate -y /dev/loop21 -ff $ vgcreate rootvg /dev/loop20 /dev/loop21 $ lvcreate -v -y -L 50 -n rootlv rootvg Add the missing pacakge to PACKAGECONFIG[udev] runtime depends could fix the issue. Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-09-11lvm2/libdevmapper: Make it build for nativePeter Kjellerstedt
Backport a patch from upstream master that corrects the passing of link flags through configure. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-09-03lvm2: fix blkdeactivate failed with command not foundHongxu Jia
Run blkdeactivate failed: ... root@intel-x86-64:~# /usr/sbin/blkdeactivate Deactivating block devices: /usr/sbin/blkdeactivate: line 345: /bin/lsblk: No such file or directory /usr/sbin/blkdeactivate: line 345: /bin/sort: No such file or directory /usr/sbin/blkdeactivate: line 345: /bin/lsblk: No such file or directory /usr/sbin/blkdeactivate: line 384: SKIP_DEVICE_LIST: bad array subscript ... - Add missing runtime depends - Set location of the commands Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-08-24libdevmapper/lvm2: force recipe libdevmapper to populate sysroot onlyHongxu Jia
Previously, in order to fix circular dependencies, we split libdm from lvm2 as a new recipe libdevmapper, and as running result proved, we need to keep both of them built with the same configuration option With new configuration options added, it is hard to keep them the same, so we make recipe libdevmapper to populate libdevmapper sysroot only, and make lvm2 to provide package libdevmapper. In this situation, option differ does not affect header and library API between lvm2 and libdevmapper, although lvm2 and libdevmapper are different at build time, but there is only one lvm2 at run time Side effect: - If one recipe DEPENDS on libdevmapper, it has to add libdevmapper to its RDEPENDS or add lvm2 to DEPENDS, otherwise, there will be a [file-rdeps] or [build-deps] QA warning - It has to add `PREFERRED_RPROVIDER_libdevmapper = "lvm2"' to local.conf to workaound 'Multiple providers' NOTE Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-08-24lvm2: fix circular dependencies while systemd enable cryptsetupHongxu Jia
While systemd enable cryptsetup (PACKAGECONFIG_append_pn-systemd = ' cryptsetup'), there is a circular dependencies: systemd -> systemd -> cryptsetup -> libdevmapper -> udev (PREFERRED_PROVIDER_udev = systemd) The libdevmapper was used to break circular dependencies, it does not require udev, refer commit [698d512 lvm2: Add a PACKAGECONFIG for udev support] to move udev related from lvm2.inc to lvm2.bb Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-08-14lvm2: Fix RDEPEND on lvm2 to lvm2-udevrulesArturo Buzarra
Commit c6e963f9e ("lvm2: Add RDEPEND on lvm2 to lvm2-udevrules") added a package dependency due to lvm2-udevrules needs dmsetup, however dmsetup was moved to libdevmapper in commit 269d009a81d4 ("lvm2: libdevicemapper package needs udev rules and dmsetup"), so this dependency should be only for libdevmapper instead of the full package. With the current implementation, a package that has a dependency with lvm2-udev rules will include also many unnecessary packages like lvm2, lvm2-scripts, etc. and their dependencies. Signed-off-by: Arturo Buzarra <arturo.buzarra@digi.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-08-02meta-oe: Change some ftp:// URIs to http(s)://Adrian Bunk
For glibmm this is done with the gnomebase class. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-03-03lvm2/libdevmapper: 2.03.01 -> 2.03.02Kai Kang
Upgrade lvm2/libdevmapper from 2.03.01 to 2.03.02. * update SRC_URI back to use ftp url - 2.03.02 has been released but no such tag in git repo - subdir 'releases' on ftp site should be a persistent place for tarballs * drop 0003-include-fcntl.h-for-O_-defines-and-fcntl-signature.patch which is not needed any longer * remove backpoort patch * update patch contexts Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-02-25lvm2: lvmdiskscan always print out "/dev/hdc: open failed: No medium found".Jiping Ma
commit [57bb46c5e7f8] introduce this issue. "/dev/hdc: open failed: No medium found" will be print out after run lvmdiskscan. change dev_open_readonly() to dev_open_readonly_quiet() in fuction _dev_get_size_dev(). Signed-off-by: Jiping Ma <jiping.ma2@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-02-22lvm2: fix lvm2-monitor.service startup failedChangqing Li
Issue: vm2-monitor.service: Failed to create lvm2-monitor.service/start: Unit lvm2-lvmetad.socket not found lvmetad have been removed by upstream, but this part is missed, backport fix from upstream Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-18lvm2/libdevmapper: drop unnecessary UPSTREAM_CHECK_URI and UPSTREAM_CHECK_REGEXHongxu Jia
Since switch to github [a7bc7b6 lvm2/libdevmapper: 2.02.180 -> 2.03.01], UPSTREAM_CHECK_URI and UPSTREAM_CHECK_REGEX is not necessary Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-27lvm2/libdevmapper: 2.02.180 -> 2.03.01Hongxu Jia
- Upddate upstream SRC_URI, use github to replace tarball - Rebase 0001-Avoid-bashisms-in-init-scripts.patch, 0005-do-not-build-manual.patch, 0001-explicitly-do-not-install-libdm.patch - Remove `--enable-applib' since upstream [0d22b58 liblvm: remove lvmapi] - Remove `lvmetad' since upstream [117160b Remove lvmetad] - Remove `oe_runmake ... -C tools install_device-mapper' since upstream [0524829 dmsetup: move to libdm/dm-tools/dmsetup] Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-03lvm2.inc: Correct the license (LGPL-2.0 -> LGPL-2.1)Peter Kjellerstedt
The library parts are actually LGPL-2.1, not LGPL-2.0. License-Update: The correct license is LGPL-2.1, not LGPL-2.0. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-01lvm2: update SRC_URIMingli Yu
Update SRC_URI for lvm2 as the previous one is invalid. Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com> Tested-by: Stefan Agner <stefan.agner@toradex.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-24lvm2: Add RDEPEND on lvm2 to lvm2-udevrulesAlex Kiernan
Some of the rules installed as part of lvm2-udevrules need to run dmsetup, so add the dependency on lvm2 in order to ensure these can execute correctly. This fixes cryptsetup hanging when creating volumes. Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-14libdevmapper: Install dmsetupAndrew Bresticker
Commit 6aa1dd223a140 ("lvm2/libdevmapper: fix invoking lvcreate failed") moved installation of dmsetup back to lvm2 from libdevmapper, but dmsetup had intentionally been moved to libdevmapper in commit 269d009a81d4 ("lvm2: libdevicemapper package needs udev rules and dmsetup"). Add it back to libdevmapper by explicitly installing it in do_install(), and refresh explicitly-do-not-install-libdm.patch so that we also explicitly do not install dmsetup as part of lvm2. Signed-off-by: Andrew Bresticker <abrestic@waymo.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-04lvm2: fix install file conflict with multilibKai Kang
When enable multilib and both lvm2 and multilib lvm2 such as lib32-lvm2 are installed to image, it causes install file conflict. | file /etc/lvm/lvm.conf conflicts between attempted installs of | lib32-lvm2-2.02.180-r0.x86 and lvm2-2.02.180-r0.core2_64 Inherit multilib_script to fix it. Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-08-02lvm2/libdevmapper: 2.02.177 -> 2.02.180Hongxu Jia
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-07-16nativesdk-lvm2: Fix installed-vs-shipped errorsOvidiu Panait
Fix the following build errors: $ bitbake nativesdk-lvm2 ERROR: nativesdk-lvm2-2.02.177-r0 do_package: QA Issue: nativesdk-lvm2: Files/directories were installed but not shipped in any package: /etc /etc/lvm /etc/lvm/lvmlocal.conf /etc/lvm/lvm.conf /etc/lvm/profile /etc/lvm/profile/metadata_profile_template.profile /etc/lvm/profile/cache-smq.profile /etc/lvm/profile/thin-generic.profile /etc/lvm/profile/command_profile_template.profile /etc/lvm/profile/cache-mq.profile /etc/lvm/profile/thin-performance.profile /etc/lvm/profile/lvmdbusd.profile ... nativesdk-lvm2: 12 installed and not shipped files. [installed-vs-shipped] Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-05-29lvm2: add UPSTREAM_CHECK_URIYi Zhao
Signed-off-by: Yi Zhao <yi.zhao@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-05-26lvm2: refresh patchesArmin Kuster
used quilt to refresh Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-05-17lvm2: 2.02.171 -> 2.02.277Hong Liu
Upgrade lvm2 from 2.02.171 to 2.02.277. Signed-off-by: Hong Liu <hongl.fnst@cn.fujitsu.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2017-10-04lvm2: refactoring code to disable package config thin-provisioning-toolsKai Kang
There are 2 GPL variations 'GPLv3' and 'GPLv3.0' for canonical (SPDX) form of 'GPL-3.0' now. Refactoring code to use function incompatible_license_contains() from license.bbclass to filter them all to disable package config 'thin-provisioning-tools'. Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-09-22lvm2: fix start lvm2-monitor.service failedHongxu Jia
While systemd based, start lvm2-monitor.service failed. ... |Sep 21 05:37:34 qemux86-64 lvm[389]: /var/lock: stat failed: No such file or directory |Sep 21 05:37:34 qemux86-64 systemd[1]: lvm2-monitor.service: Main process exited, code=exited, status=5/NOTINSTALLED ... The failure of lvm2-monitor.service caused reboot hung when disk partion is lvm thin provision. While starting lvm2-monitor.service, it reqires the existence of locking dir "/var/lock" which is a symlink to "../run/lock" in oe-core, and "/run" is created in "/etc/fstab" which have to be be after the start of lvm2-monitor.service. So tweak the locking dir to "/tmp/lock" and make sure the dir existence (after tmp.mount). Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-09-22lvm2: disable thin provisioning support if GPLv3 incompatibleKai Kang
Disable thin provisioning support for lvm2 if it is set GPLv3 incompatible. Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-09-18lvm2: Add HOMEPAGE info into recipe file.Huang Qiyu
Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-08-13lvm2/libdevmapper: workaround build man failureHongxu Jia
On some host (ubuntu 1404), build manual failed. ... ./tools/man-generator --primary lvscan lvscan.8_des Failed to stat description file lvscan.8_des. ... Do not build man to workaround the issue. Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-06-22libdevmapper: sync with lvm2 2.02.171Hongxu Jia
Both of libdevmapper and lvm2 should have the same version. Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-06-05lvm2/libdevmapper: fix invoking lvcreate failedHongxu Jia
Previously, libdevmapper is separated from lvm2 in the following commit: Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-05-23lvm2: 2.02.166 -> 2.02.171Huang Qiyu
Upgrade lvm2 from 2.02.166 to 2.02.171. Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-05-23libdevmapper: enable native support.Ismo Puustinen
Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-04-26lvm2: separate libdevmapper to avoid circular dependencyChen Qi
If we enable 'cryptsetup' PACKAGECONFIG for systemd, there would be circular dependency issue among 'systemd', 'cryptsetup' and 'lvm2'. cryptsetup only needs libdevmapper from lvm2. So we separte libdevmapper into a new recipe to solve this circular dependency issue. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-04-06lvm2: Fix patch errors found with muslKhem Raj
The patches had syntax errors which are only visible when using musl libs Signed-off-by: Khem Raj <raj.khem@gmail.com>
2017-03-31lvm2: fix lvm2-native RRECOMMENDS problemPatrick Ohly
lvm2-native doesn't have packages, so the RRECOMMENDS must be limited to the target case. This fixes: ERROR: Nothing RPROVIDES 'lvm2-native-scripts-native' (but virtual:native:.../meta-openembedded/meta-oe/recipes-support/lvm2/lvm2_2.02.166.bb RDEPENDS on or otherwise requires it) Signed-off-by: Patrick Ohly <patrick.ohly@intel.com> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-03-31lvm2: libdevicemapper package needs udev rules and dmsetupPatrick Ohly
Applications like kpartx and cryptsetup were broken by moving only libdevicemapper itself into a separate package: as a result of that change, lvm2 was not getting pulled into images anymore although libdevicemapper depends on dmsetup and udev rules to be fully functional. For example, "kpartx -as" started to hang while waiting for the udev rules to trigger, which is what creates the /dev/mapper/ entries for the new partitions (see also https://github.com/docker/docker/issues/22025#issuecomment-243943728). Putting udev rules and dmsetup also into libdevicemapper is perhaps counter-intuitive, but necessary to keep the package functioning. A full lvm2 installation is guaranteed to pull them in, too, both because of implicit library dependencies and (just to be sure) an explicit RDEPENDS. lvm2-native doesn't have packages, so this RDEPENDS must be limited to the target case. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-03-31lvm2: Avoid an unnecessary dependency on bashPeter Kjellerstedt
Rather than having the lvm2 package depend on bash, modify the init scripts it may contain to use /bin/sh instead of /bin/bash. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-03-16lvm2: fix bash depends QA issueArmin Kuster
WARNING: lvm2-2.02.166-r0 do_package_qa: QA Issue: /etc/init.d/lvm2-monitor contained in package lvm2 requires /bin/bash, but no providers found in RDEPENDS_lvm2? [file-rdeps] Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-03-07Make use of the new bb.utils.filter() functionPeter Kjellerstedt
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-02-23lvm2: Replace 'lib' with ${nonarch_base_libdir} for placing udev rules.Amarnath Valluri
Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-02-22lvm2: Move libdevmapper to a separate packagePeter Kjellerstedt
This allows, e.g., cryptsetup to use libdevmapper without having to pull in all of lvm2. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-02-22lvm2: Move bash scripts to a separate packagePeter Kjellerstedt
By putting the bash scripts in a separate package (lvm2-scripts), the lvm2 package no longer needs to depend on bash. For backwards compatibility, the lvm2 package recommends the lvm2-scripts package. Also remove the adding of ${libdir}/device-mapper/.debug to FILES_${PN}-dbg as it has not been needed since Krogoth. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>