diff options
| author |   Kang Kai <kai.kang@windriver.com> | 2012-06-14 18:10:57 +0800 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-06-14 14:07:17 +0100 |
| commit | d2bdfe0e667820718dcfefd845c1b28ccdd31e82 (patch) | |
| tree | 81c740ccad7603d6223a87a99d90a68737a02baf /bitbake | |
| parent | a87ce4308e51364ea91b8f8448d2d7644e702054 (diff) | |
| download | openembedded-core-contrib-d2bdfe0e667820718dcfefd845c1b28ccdd31e82.tar.gz | |
ui/crumbs/hig.py: simplify subprocess call
According to Darren's suggestion, subprocess.call() will wait until the
subprocess complete. So simplify the code, use subprocess.call() to wait
command complete.
(Bitbake rev: 3dea9d5a5af82d99d337238981807a4cb1bd5b93)
Signed-off-by: Kang Kai <kai.kang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake')
| -rw-r--r-- | bitbake/lib/bb/ui/crumbs/hig.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/bitbake/lib/bb/ui/crumbs/hig.py b/bitbake/lib/bb/ui/crumbs/hig.py index 0c3f56c432..b586b6c274 100644 --- a/bitbake/lib/bb/ui/crumbs/hig.py +++ b/bitbake/lib/bb/ui/crumbs/hig.py @@ -27,6 +27,7 @@ import hashlib import os import re import shlex +import subprocess from bb.ui.crumbs.hobcolor import HobColors from bb.ui.crumbs.hobwidget import hcc, hic, HobViewTable, HobInfoButton, HobButton, HobAltButton, HobIconChecker from bb.ui.crumbs.progressbar import HobProgressBar @@ -871,8 +872,7 @@ class DeployImageDialog (CrumbsDialog): tmpname = os.tmpnam() cmdline += "\"sudo dd if=" + self.image_path + \ " of=" + combo_item + "; echo $? > " + tmpname + "\"" - deploy_process = bb.process.Popen(shlex.split(cmdline)) - deploy_process.wait() + subprocess.call(shlex.split(cmdline)) # if file tmpname not exists, that means there is something wrong with xterm # user can get the error message from xterm so no more warning need. |