aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* conf/multilib.conf: Add ovmf to NON_MULTILIB_RECIPESrbt/mlibRobert Yang2019-09-111-1/+1
| | | | | | | | | | | | | | | | | | | | | Fixed: MACHINE = "qemux86-64" require conf/multilib.conf MULTILIBS = "multilib:lib32" DEFAULTTUNE_virtclass-multilib-lib32 = "x86" $ bitbake ovmf lib32-ovmf [snip] ERROR: ovmf-edk2-stable201905-r0 do_deploy_setscene: The recipe ovmf is trying to install files into a shared area when those files already exist. Those files and their manifest location are: /buildarea1/lyang1/rebase-work/test_cc/tmp-glibc/deploy/images/qemux86-64/OvmfPkKek1.key (matched in manifest-qemux86_64-lib32-ovmf.deploy) [snip] Add it NON_MULTILIB_RECIPES to fix the problem since it is a firmware, build multilib for it doens't make much sense. Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
* libevent: don't treat test stats line as pass/fail in ptestTrevor Gamblin2019-09-111-4/+5
| | | | | | | | | | | | | | | | | Supplemental to commit fb17b46e2. The libevent "regress" test outputs its own pass/fail results, e.g. "2/300 TESTS FAILED. (31 skipped)", which will be miscounted as an extra test fail in the ptest log. Fixed this to ignore the libevent results line when counting actual pass/fail results. Also removed the for loop in run-ptest and targeted only the libevent "regress" test, as the other tests being run were related to performance and did not provide a relevant pass/fail output. Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* chrpath.bbclass: Add break_hardlinks kwarg to allow breaking hardlinksNathan Rossi2019-09-111-6/+13
| | | | | | | | | Add the break_hardlinks kwarg to break hardlinks when modifying files. This uses the bb.utils.break_hardlinks function to break hardlinks. The default is to maintain existing behaviour and leave hardlinks in place. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/context.py: For -t/-T use append argparse actionNathan Rossi2019-09-111-6/+6
| | | | | | | | | | | Use the 'append' action of argparse instead of nargs. This changes the behaviour of the option from "-t foo bar -r" to "-t foo -t bar -r". Additionally rename the long form options to be consistent with behaviour, such that they specifying a single tag at a time. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest: Tweak binutils tests tags as toolchain/user and systemRichard Purdie2019-09-071-1/+1
| | | | | | This matches the other toolchain tests. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/cases/glibc.py: Rework and tag with toolchain-user/systemNathan Rossi2019-09-071-21/+25
| | | | | | | | Rework the glibc execution into a common base class. Additionally tag the tests with "toolchain-user" and "toolchain-system". Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/cases/gcc.py: Split into classes for parallelismNathan Rossi2019-09-071-30/+71
| | | | | | | | | | | | Split the gcc selftest cases into multiple classes one for each test. This is done in order to make it easy to execute multiple gcc tests in parallel when using oe-selftest with the '-j' arg. Additionally tag the user tests with "toolchain-user" and the system emulation (qemu system) tests with "toolchain-system". Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/core/decorator: Fix super class modifying subclass tagsNathan Rossi2019-09-071-1/+2
| | | | | Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/context.py: Change -t/-T args to be optionalNathan Rossi2019-09-071-11/+19
| | | | | | | | | Change the -t/-T args to be optional so that they can be used together with the existing -r/-a/... args to run a more flexible filtering of test tags. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest: Use extraresults on self instead of self.tcNathan Rossi2019-09-074-41/+12
| | | | | | | | | | | In order to take advantage of multiprocess execution of tests the extraresults must be passed through the TestResult. With changes to how oeqa/core handles test cases the extraresults attribute of the testcase is passed to the TestResult, with passing across process boundaries handled automatically. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest: Toolchain tests suffix "-user" for qemu usermode resultsNathan Rossi2019-09-072-2/+4
| | | | | | | | Suffix the ptestresults suite with "-user" for tests that are executing against usermode qemu. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest: For toolchain tests do not fail if a test failedNathan Rossi2019-09-073-17/+0
| | | | | | | | | | | Do not fail the running selftest test case if the test suite has a failed test case. Currently toolchain tests suites (binutils, gcc, glibc) fail but this does not indicate failure to execute the tests. Also remove the logging of each test that failed. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/cases/glibc.py: Don't install python3 and pexpectNathan Rossi2019-09-071-2/+2
| | | | | | | | | When running the system emulation test case, do not include python3 or pexpect in the image. The test cases that use these also need gdb (with python configured). Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/glibc: Create selftest case for glibc test suiteNathan Rossi2019-09-071-0/+97
| | | | | | | | | | | | | | | Create a oeqa selftest test case to execute the glibc test suite and report the results. The results are populated into the extraresults variable of the test case which are written to testresults.json for resulttool to analyse. An additional subclass is created to separate the execution with qemu linux-user and qemu system. The GlibcSelfTestSystemEmulated test case handles setup of the target image, setup of and NFS server as well as execution with runqemu. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/gcc: Create selftest case for gcc test suiteNathan Rossi2019-09-071-0/+111
| | | | | | | | | | | | | | Create a oeqa selftest test case to execute the gcc test suites and report the results. The results are populated into the extraresults variable of the test case which are written to testresults.json for resulttool to analyse. An additional subclass is created to separate the execution with qemu linux-user and qemu system. The GccSelfTestSystemEmulated test case handles setup of the target image as well as execution with runqemu. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest/binutils: Create selftest case for binutils test suiteNathan Rossi2019-09-071-0/+64
| | | | | | | | | | Create a oeqa selftest test case to execute the binutils test suites and report the results. The results are populated into the extraresults variable of the test case which are written to testresults.json for resulttool to analyse. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest: Markup 'machine' specific test casesRichard Purdie2019-09-072-0/+4
| | | | | | | | These test cases are run by the autobuilder on a machine specific basis. Add tags to these classes so they can be controlled by the metadata rather than hardcoded in the autobuilder config. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/core/runner.py: Fix OETestTag listingNathan Rossi2019-09-071-11/+8
| | | | | | | | | | Use the __oeqa_testtags attribute added by OETestTag and display no, one or more tags separated by a comma. Also change the formatting of the output so that the list of tests is formatted as "<test> (<tags>)" and remove the table header for "id" (it is no longer available). Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/selftest: Add test run filtering based on test tagsNathan Rossi2019-09-071-0/+11
| | | | | | | | | Add '--run-only-tags' for running tests which match any of the provided tags, and '--run-exclude-tags' for running all tests except those that have any of the provided tags. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/core: Rework OETestTag and remove unused OETestFilterNathan Rossi2019-09-079-138/+103
| | | | | | | | | | | | | | | | | | | | Rework OETestTag so that it does not rely on the existing decorator code base and instead inserts the tags into an attribute on the decorated target (e.g. class/type or method). This allows the use of OETestTag on classes and method. In order to filter tagged tests rework the loaders filtering code, removing the generic-ness (with validation and attributes/etc.) and replace it with a "tags_filter" parameter which is a function that filters a test based on the tags it has. This allows the loader user to filter on tags in more specific ways (e.g. include all untagged tests and any tests tagged with foo). Plumb all this through the context code and testing code. Update the associated tests to pass correctly with the changes. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa/core: Implement proper extra result collection and serializationNathan Rossi2019-09-072-6/+96
| | | | | | | | | | | | | Implement handling of extra result (e.g. ptestresult) collection with the addition of a "extraresults" extraction function in OETestResult. In order to be able to serialize and deserialize the extraresults data, allow OETestResult add* calls to take a details kwarg. The subunit module can handle cross-process transfer of binary data for the details kwarg. With a TestResult proxy class to sit inbetween to encode and decode to and from json. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* python3-manifest.json: Fix typo in summaryKhem Raj2019-09-071-1/+1
| | | | | Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* linux-yocto: drop 5.0 recipesBruce Ashfield2019-09-073-130/+0
| | | | | | | | The 5.2 reference kernels replace the EOL 5.0 series. So we drop the named recipes. Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libevent: add granularity to ptest logTrevor Gamblin2019-09-072-12/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The libevent ptest used to report only a global pass or a fail result. Count individual PASS, FAIL, SKIP results. The SKIP results now include tests that are disabled in the libevent code. libevent's ptest output did not comply with the automake-style output "result: testname", and reported a FAIL status at the end of the test run if any of the libevent tests failed. This patch makes the log consistent with the automake style: PASS: http/cancel_by_host_no_ns PASS: http/cancel_inactive_server PASS: http/cancel_by_host_no_ns_inactive_server SKIPPED: http/cancel_by_host_server_timeout SKIPPED: http/cancel_server_timeout and provides a summary as follows: === Test Summary === TOTAL: 316 PASSED: 300 FAILED: 0 SKIPPED: 16 DURATION: 87 END: /usr/lib/libevent/ptest Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* diffutils: Added perl to support ptest & Skipped one test casePeiran Hong2019-09-072-1/+37
| | | | | | | | | | Added perl to the run-time dependency of the recipe for diffutils since it is required by the test "large-subpot". The test "strip-trailing-cr" is skipped since it requires valgrind to work, but valgrind is considered too heavy-weight for diffutils package. Signed-off-by: Peiran Hong <peiran.hong@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* oeqa: Recognise svlogd as another loggerKhem Raj2019-09-071-1/+1
| | | | | | | | This is provided by runit which another init system like systemd, sysvinit, this lets oeqa run on systems which are using runit Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libxcrypt: update to 4.4.8Oleksandr Kravchuk2019-09-072-4/+2
| | | | | | | | LICENSE file checksum changed because few contributors were mentioned (see @edbdbbc50beced9c723e7405334583c60a702796). Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dropbear: don't create invalid symlinks if ssh, scp, etc are disabledAndre McCurdy2019-09-071-2/+9
| | | | | Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* feature-arm-thumb.inc: fix ARM_THUMB_SUFFIXAndre McCurdy2019-09-071-2/+5
| | | | | | | | | Since TUNE_FEATURES now either contains a CPU or an architecture (but not both) we can't rely on finding the architecture in TUNE_FEATURES. Use architecture specific over-rides instead. Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* iputils: Set prefix correctly for usrmergeAlex Kiernan2019-09-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Fix build with usrmerge enabled: WARNING: iputils-s20190709-r0 do_package: iputils: alternative target (/usr/bin/ping or /usr/bin/ping.iputils) does not exist, skipping... WARNING: iputils-s20190709-r0 do_package: iputils: NOT adding alternative provide /usr/bin/ping: /usr/bin/ping.iputils does not exist ERROR: iputils-s20190709-r0 do_package: QA Issue: iputils: Files/directories were installed but not shipped in any package: /bin/tftpd /bin/tracepath /bin/arping /bin/clockdiff /bin/ping /bin/traceroute6 /sbin/rarpd /sbin/ninfod /sbin/rdisc Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. iputils: 9 installed and not shipped files. [installed-vs-shipped] WARNING: iputils-s20190709-r0 do_package: iputils: alt_link == alt_target: /usr/bin/ping == /usr/bin/ping Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* man-db: support usrmergeChangqing Li2019-09-071-1/+1
| | | | | Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* dnf.py: installroot support usrmergeChangqing Li2019-09-071-1/+33
| | | | | Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* sysstat: 12.1.3 -> 12.1.6Kai Kang2019-09-072-4/+4
| | | | | | | | | | Update sysstat from 12.1.3 to 12.1.6. * make sa_lib_dir refer to ${libexecdir}/sa to fix conflictions when multilib is enabled Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* texinfo: fix multilib file conflictionKai Kang2019-09-071-1/+3
| | | | | | | | | | | Inherit multilib_script to fix file confliction when mutlilib enabled. | Error: Transaction check error: | file /usr/bin/texi2any conflicts between attempted installs of lib32-texinfo-6.5-r0.core2_32 and texinfo-6.5-r0.core2_64 Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* cups: redefine CUPS_SERVERBINKai Kang2019-09-072-3/+9
| | | | | | | | | | | | Redefine CUPS_SERVERBIN to "$libexecdir/cups" for cups which solves file confliction when multilib is enabled. | Error: Transaction check error: | file /lib/systemd/system/org.cups.cups-lpd@.service conflicts between attempted installs of cups-2.2.11-r0.core2_64 and lib32-cups-2.2.11-r0.core2_32 Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* python3native, pythonnative: export PYTHON_LIBRARY and PYTHON_INCLUDE_DIRKhem Raj2019-09-072-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | packages can use find_package(PythonInterp REQUIRED) find_package(PythonLibs REQUIRED) while we control PYTHON pointing to native py3 the libs and include directories will then point to build host version, which can result in unexpected combination and if we are lucky we get errors if its quite different e.g. py2 libs/includes and py3 executable This variable can be then used to export PYTHON_LIBRARY and PYTHON_INCLUDE_DIR so that above find_packages can work correctly see [1] for how it happens in cmake LLDB uses it see [2] [1] https://github.com/Kitware/CMake/blob/master/Modules/FindPythonLibs.cmake [2] https://github.com/llvm/llvm-project/blob/master/lldb/cmake/modules/LLDBConfig.cmake#L226 Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* python3: make misc package rdepend on pydoc and pickle modulesChen Qi2019-09-071-1/+1
| | | | | | | | The cgitb module in misc package requires pydoc. And the trace module in misc package requires pickle. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mdadm: skip timeout testcase 11spare-migrationChangqing Li2019-09-072-0/+45
| | | | | | | [YOCTO #13368] Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bootchart2: switch to add patch from change source in do_installChangqing Li2019-09-072-4/+40
| | | | | | | | | | it is not proper change source in do_install, it will make source not updated even local.conf have change the DISTRO_FEATURES [YOCTO #13493] Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Revert "kernel.bbclass: adjust a condition checking"Jason Wessel2019-09-061-2/+4
| | | | | | | | | | | | | | | | | This reverts commit 6676411fccff2d331878e4ca1f9411aafb056a80. This revert restores the original code and adds a comment. The commit that was reverted broke a number of wic templates and tools which rely on the initramfs creation dependency and the case where the INITRAMFS_IMAGE_BUNDLE is not set. If an end user does not want the INITRAMFS_IMAGE generated, it should be set to "". [ Issue: LIN1019-1791 ] Signed-off-by: Jason Wessel <jason.wessel@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* meson:upgrade 0.51.1 -> 0.51.2Zang Ruochen2019-09-064-103/+2
| | | | | | | | -meson/0001-Fix-missing-return-statements-that-are-seen-with-Wer.patch Removed since this is included in 0.51.2. Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
* weston: uprev to 7.0.0Ming Liu2019-09-063-106/+28
| | | | | | | | - Adjust patches to comply with weston-7.0.0. - Also drop the obsolete patch 0001-make-error-portable.patch. Signed-off-by: Ming Liu <liu.ming50@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
* systemd: ensure reproducible builds by clearly exposing the time epoch supportRoss Burton2019-09-061-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | systemd has the ability to check the time on boot and if it's earlier than an epoch determined at build time, set the time to that epoch. This is useful for systems where the system time is January 1st 1970 (because the unix timestamp was 0 at boot) as then at least the time is reset to something approximating the right year at least. By default systemd uses the mtime of the NEWS file, which is static for tarballs and corresponds to the time the release was made, but for git checkouts this is simply the time do_unpack() was executed. Thus, rebuilding systemd will cause this embedded timestamp to change. Remove the PACKAGECONFIG time-epoch which has the logic reversed: enabling time-epoch will set the epoch to the unix timestamp 0). Replace with set-time-epoch with the following semantics: - When disabled, the time epoch is set to 0 (1st January 1970), so there is no time manipulation on boot. - When enabled, if reproducible builds are configured by setting SOURCE_DATE_EPOCH then that timestamp is used for the time epoch. If reproducible builds are not configured then the timestamp of NEWS (thus the build time) is used. The set-time-epoch flag is enabled by default. [ YOCTO #13473 ] Signed-off-by: Ross Burton <ross.burton@intel.com>
* python3-git: update to 3.0.2Oleksandr Kravchuk2019-09-061-2/+2
| | | | | Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
* python3-pbr: update to 5.4.3Oleksandr Kravchuk2019-09-062-5/+5
| | | | | Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
* resulttool: Add reproducible log extractionJoshua Watt2019-09-061-3/+30
| | | | | | | | | | | | | | Adds an argument to the log subcommand to extract the raw logs from the reproducible selftest. To prevent ambiguity, the "--raw" argument has been renamed "--raw-ptest", although the old "--raw" argument is kept around for compatibility. [YOCTO #13324] Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
* libsecret: 0.19.0Oleksandr Kravchuk2019-09-061-2/+2
| | | | | Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
* autotools: always include config_site.d files in CONFIG_SITEDan Callaghan2019-09-061-2/+5
| | | | | | | Fixes: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13375 Signed-off-by: Dan Callaghan <dan.callaghan@opengear.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
* python3-dbus:upgrade 1.2.8 -> 1.2.10Zang Ruochen2019-09-061-2/+2
| | | | | Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
* package.bbclass: allow shell-style wildcards in PRIVATE_LIBSAlexander Kanavin2019-09-061-2/+4
| | | | | | | | | | | | | PRIVATE_LIBS is used to exclude 'private' libraries from getting added to automatic runtime dependency resolution. This variable currently has to list all libraries by name, which becomes a maintenance issue if the list of such libraries frequently changes, or is very large. This change allows using shell-style wildcards in the variable, similar to how FILES lists what gets packaged. Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>