From 1dd92fbdc030bee30a0c5b233f7b61ac0cb2b459 Mon Sep 17 00:00:00 2001 From: Ross Burton Date: Fri, 9 Oct 2015 17:50:41 +0100 Subject: icu: fix install race ICU was invoking install-local twice in parallel which can lead to install failures as one install deletes files the other is attempting to chown. Signed-off-by: Ross Burton --- .../recipes-support/icu/icu/fix-install-manx.patch | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 meta/recipes-support/icu/icu/fix-install-manx.patch (limited to 'meta/recipes-support/icu/icu') diff --git a/meta/recipes-support/icu/icu/fix-install-manx.patch b/meta/recipes-support/icu/icu/fix-install-manx.patch new file mode 100644 index 0000000000..ec63f50c46 --- /dev/null +++ b/meta/recipes-support/icu/icu/fix-install-manx.patch @@ -0,0 +1,48 @@ +The generic recursive target calls target-local so also adding it to the +dependency list results in races due to install-local being executed twice in +parallel. For example, install-manx can fail if the two install processes race +and one process tries to chown a file that the other process has just deleted. + +Also install-manx should be a phony target, and for clarity use $^ instead of $? +in the install command. + +Upstream-Status: Pending +Signed-off-by: Ross Burton + + +diff --git a/Makefile.in b/Makefile.in +index 9db6c52..3441afa 100644 +--- a/Makefile.in ++++ b/Makefile.in +@@ -71,7 +71,7 @@ EXTRA_DATA = + + ## List of phony targets + .PHONY : all all-local all-recursive install install-local install-udata install-udata-files install-udata-dlls \ +-install-recursive clean clean-local clean-recursive distclean \ ++install-recursive install-manx clean clean-local clean-recursive distclean \ + distclean-local distclean-recursive doc dist dist-local dist-recursive \ + check check-local check-recursive clean-recursive-with-twist install-icu \ + doc install-doc tests icu4j-data icu4j-data-install update-windows-makefiles xcheck-local xcheck-recursive xperf xcheck xperf-recursive \ +@@ -82,10 +82,10 @@ check-exhaustive check-exhaustive-local check-exhaustive-recursive releaseDist + + ## List of standard targets + all: all-local all-recursive +-install: install-recursive install-local ++install: install-recursive + clean: clean-recursive-with-twist clean-local +-distclean : distclean-recursive distclean-local +-dist: dist-recursive dist-local ++distclean : distclean-recursive ++dist: dist-recursive + check: all check-recursive + check-recursive: all + xcheck: all xcheck-recursive +@@ -352,7 +352,7 @@ config.status: $(srcdir)/configure $(srcdir)/common/unicode/uvernum.h + + install-manx: $(MANX_FILES) + $(MKINSTALLDIRS) $(DESTDIR)$(mandir)/man$(SECTION) +- $(INSTALL_DATA) $? $(DESTDIR)$(mandir)/man$(SECTION) ++ $(INSTALL_DATA) $^ $(DESTDIR)$(mandir)/man$(SECTION) + + config/%.$(SECTION): $(srcdir)/config/%.$(SECTION).in + cd $(top_builddir) \ -- cgit 1.2.3-korg