aboutsummaryrefslogtreecommitdiffstats
path: root/meta/recipes-kernel/linux-libc-headers/linux-libc-headers/0001-scripts-Use-fixed-temporary-file-instead-of-pipe-for.patch
blob: 0d8fa80939f9dc7b5964b78722e2945073c04b52 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
From 3bbea65e11918f8753e8006a2198b999cdb0af58 Mon Sep 17 00:00:00 2001
From: He Zhe <zhe.he@windriver.com>
Date: Wed, 21 Nov 2018 15:12:43 +0800
Subject: [PATCH] scripts: Use fixed temporary file instead of pipe for
 here-doc

There was a bug of "as" in binutils that when it checks if the input file and
output file are the same one, it would not check if they are on the same block
device. The check is introduced by the following commit in v2.31.

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=
67f846b59b32f3d704c601669409c2584383fea9

The here-doc usage in this script creates temporary file in /tmp. When we run in
an environment where /tmp has rarely been used, the newly created temporary file
may have a very low inode number. If the inode number was 6 which is the same as
/dev/null, the as would wrongly think the input file and the output file are the
same and report the following error.

*** Compiler lacks asm-goto support.. Stop.

One observed case happened in docker where the /tmp could be so rarely used that
very low number inode may be allocated and triggers the error.

The fix below for the bug only exists on the master branch of binutils so far
and has not been released from upstream. As the convict is introduced since
v2.31, only v2.31 is affected.

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=
2a50366ded329bfb39d387253450c9d5302c3503

When building linux-libc-headers we need to use "as" in binutils which does not
contain the fix for the moment. To work around the error, we create a fixed
temporary file to contain the program being tested.

This patch also removes ">/dev/null 2>&1" so we will have more direct error
information in case something else wrong happened.

Upstream-Status: Inappropriate [A work around for binutils v2.31]

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 scripts/gcc-goto.sh | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/scripts/gcc-goto.sh b/scripts/gcc-goto.sh
index 083c526..0aaf1b4 100755
--- a/scripts/gcc-goto.sh
+++ b/scripts/gcc-goto.sh
@@ -3,7 +3,9 @@
 # Test for gcc 'asm goto' support
 # Copyright (C) 2010, Jason Baron <jbaron@redhat.com>
 
-cat << "END" | $@ -x c - -c -o /dev/null >/dev/null 2>&1 && echo "y"
+TMPFILE=`mktemp -p .`
+
+cat << "END" > ${TMPFILE}
 int main(void)
 {
 #if defined(__arm__) || defined(__aarch64__)
@@ -20,3 +22,6 @@ entry:
 	return 0;
 }
 END
+
+$@ -x c ${TMPFILE} -c -o /dev/null && echo "y"
+rm ${TMPFILE}
-- 
2.7.4