1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
|
From 0370e7a9fb0ca1b27d7b0897739e2a7cce8977ab Mon Sep 17 00:00:00 2001
From: Khem Raj <raj.khem@gmail.com>
Date: Sat, 11 May 2024 22:42:07 -0700
Subject: [PATCH] server: Correct prameter type for connect() API
connect() function expects the second argument to be point to sockaddr
as per man sockaddr
int connect (int, const struct sockaddr *, socklen_t);
Fixes build failures with -Wincompatible-pointer-types when using GCC-14
and musl
Fixes
| server.c: In function 'server_ping':
| server.c:308:33: error: passing argument 2 of 'connect' from incompatible pointer type [-Wincompatible-pointer-types]
| 308 | if (connect(fd, un, sizeof(struct sockaddr_un)) < 0)
| | ^~
| | |
| | struct sockaddr_un *
Upstream-Status: Submitted [ sent to contact@mcelog.org ]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server.c b/server.c
index 54c7d57..51b7d3a 100644
--- a/server.c
+++ b/server.c
@@ -305,7 +305,7 @@ static int server_ping(struct sockaddr_un *un)
if (sigsetjmp(ping_timeout_ctx, 1) == 0) {
ret = -1;
alarm(initial_ping_timeout);
- if (connect(fd, un, sizeof(struct sockaddr_un)) < 0)
+ if (connect(fd, (const struct sockaddr *)un, sizeof(struct sockaddr_un)) < 0)
goto cleanup;
if (write(fd, PAIR("ping\n")) < 0)
goto cleanup;
--
2.45.0
|
